Normative: Reject too large dates in ToTemporalMonthDay #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the CreateISODateRecord call in ToTemporalYearMonth after processing the options to match the steps in ToTemporalMonthDay, ToTemporalDate, and ToTemporalDateTime.
…earMonth The call to `CalendarYearMonthFromFields` will already reject too large dates, but adding an explicit step makes it more obvious that `ISODateToFields` doesn't require support for mapping large ISO dates to calendar dates. And it also aligns `ToTemporalYearMonth` with `ToTemporalMonthDay`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 21 21
Lines 9716 9716
Branches 1742 1742
=======================================
Hits 9302 9302
Misses 363 363
Partials 51 51 ☔ View full report in Codecov by Sentry. |
|
Thanks. We'll discuss this in the next champions meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3008 / #3002 to reject too large dates.