Temporal: Tests for normative changes around date-only strings #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
added
the
awaiting consensus
Aditi-1400
previously approved these changes
Oct 27, 2022
ptomato
added
has pending pr
has consensus
|
The corresponding normative change achieved consensus in the TC39 plenary meeting today. |
ptomato
force-pushed
the
temporal-2398
branch
from
9cf5e98 to
48bca78
Compare
Ms2ger
approved these changes
Nov 30, 2022
As per the discussion in tc39/proposal-temporal#2379 (comment) and the PR tc39/proposal-temporal#2398, which is to be presented for consensus to TC39 in the upcoming plenary meeting, UTC offsets and the Z designator should be disallowed after any date-only strings (YYYY-MM-DD, YYYY-MM, and MM-DD). They should only be allowed to follow a time component. Z remains disallowed in any string being parsed into a Plain type. Annotations become allowed after any ISO string, even YYYY-MM and MM-DD where they were previously disallowed.
ptomato
force-pushed
the
temporal-2398
branch
from
48bca78 to
e3a393a
Compare
sosukesuzuki
added a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Aug 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=278139 Reviewed by NOBODY (OOPS!). In the latest Temporal spec, a TimeZone after a Date without a Time should be rejected[1][2]. However, the current JSC allows such ISO 8601 strings. This PR changes to throw a RangeError when a TimeZone appears without a Time. [1]: tc39/proposal-temporal#2428 [2]: tc39/test262#3699 * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/ISO8601.cpp: (JSC::ISO8601::parseDateTime):
sosukesuzuki
added a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Aug 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=278139 Reviewed by NOBODY (OOPS!). In the latest Temporal spec, a TimeZone after a Date without a Time should be rejected[1][2]. However, the current JSC allows such ISO 8601 strings. This PR changes to throw a RangeError when a TimeZone appears without a Time. [1]: tc39/proposal-temporal#2428 [2]: tc39/test262#3699 * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/ISO8601.cpp: (JSC::ISO8601::parseDateTime):
webkit-commit-queue
pushed a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Aug 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=278139 Reviewed by Ross Kirsling. In the latest Temporal spec, a TimeZone after a Date without a Time should be rejected[1][2]. However, the current JSC allows such ISO 8601 strings. This PR changes to throw a RangeError when a TimeZone appears without a Time. [1]: tc39/proposal-temporal#2428 [2]: tc39/test262#3699 * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/ISO8601.cpp: (JSC::ISO8601::parseDateTime): Canonical link: https://commits.webkit.org/282315@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in
tc39/proposal-temporal#2379 (comment) and the PR tc39/proposal-temporal#2428, which is to be presented for consensus to TC39 in the upcoming plenary meeting, UTC offsets and the Z designator should be disallowed after any date-only strings (YYYY-MM-DD, YYYY-MM, and MM-DD). They should only be allowed to follow a time component. Z remains disallowed in any string being parsed into a Plain type.
Annotations become allowed after any ISO string, even YYYY-MM and MM-DD where they were previously disallowed.