Update tests for "Limit valid values for DurationFormats to match upcoming limits in Temporal" #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync `partitionDurationFormatPattern` with the latest spec draft and change it to use an `Intl.DurationFormat` object as the input, so it's easier to compare it against the spec text and because it allows to test more inputs. Includes the fixes for: - tc39/proposal-intl-duration-format#183 - tc39/proposal-intl-duration-format#184
…and-non-zero-seconds" The changes from the first commit allow to use `formatDurationFormatPattern` for this test.
…fault display of sub-hours units Numeric "minute" and "seconds" units now default to "always" display, so we have to add an additional test to cover when "auto" display is used. Additionally add more inputs to cover all possible test combinations.
…oming limits in Temporal" Update tests for <tc39/proposal-intl-duration-format#173>.
|
Could we merge this now? @ptomato |
|
I guess so, but you have conflicts to resolve |
@anba Thanks |
|
ping |
1 similar comment
|
ping |
|
Still conflicts |
|
@anba ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests for tc39/proposal-intl-duration-format#173.
Applies on top of #3983.