Skip to content

update Iterator Sequencing tests to reflect May 2025 plenary updates #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

update Iterator Sequencing tests to reflect May 2025 plenary updates #4523

merged 1 commit into from
Aug 22, 2025

Conversation

@michaelficarra
Copy link
Member

@michaelficarra michaelficarra commented Jun 20, 2025

These tests should match the spec changes in tc39/proposal-iterator-sequencing#26.

@michaelficarra michaelficarra requested a review from a team as a code owner June 20, 2025 02:34
@Ms2ger Ms2ger force-pushed the iterator-sequencing-may-updates branch from bdb051f to 29c5f67 Compare August 22, 2025 14:03
@Ms2ger Ms2ger enabled auto-merge (rebase) August 22, 2025 14:04
@Ms2ger Ms2ger merged commit b947715 into main Aug 22, 2025
15 checks passed
@Ms2ger Ms2ger deleted the iterator-sequencing-may-updates branch August 22, 2025 14:06
@iamstolis
Copy link
Contributor

iamstolis commented Sep 2, 2025

Shouldn't built-ins/Iterator/concat/next-method-returns-throwing-value.js be updated as well? iterator.next() did not throw before because iteratorResult was reused (i.e. its value was not read). Now, IteratorStepValue() always reads the value of the inner iterator (which throws in this case). So, iterator.next() should throw now, right?

In other words, I think that 71794b1 should be reverted now.

@ptomato ptomato mentioned this pull request Sep 15, 2025
Closed
ptomato added a commit to ptomato/test262 that referenced this pull request Sep 16, 2025
@ptomato
Revert "fix another test now that we don't access the IteratorResult …
e5f6c9f 
…value"

This reverts commit 71794b1.

Follow up from tc39#4523, missed reverting this commit.

Closes: tc39#4581
@ptomato ptomato mentioned this pull request Sep 16, 2025
Merged
Ms2ger pushed a commit that referenced this pull request Sep 16, 2025
@ptomato @Ms2ger
Revert "fix another test now that we don't access the IteratorResult …
35b3fc7 
…value"

This reverts commit 71794b1.

Follow up from #4523, missed reverting this commit.

Closes: #4581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michaelficarra @iamstolis @Ms2ger @ptomato