Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Translation to DecryptionError in matrix-js-sdk/src/crypto #357

Closed
19 tasks
mcalinghee opened this issue Jan 2, 2023 · 1 comment
Closed
19 tasks

Comments

@mcalinghee
Copy link
Contributor

mcalinghee commented Jan 2, 2023

We would like to add french translation on DecryptionError raised by matrix-js-sdk/src/crypto as they are directly displayed to users in tchap-web through TchapUnknownBody.tsx/UnknownBody.tsx

  • We could add i18n facility in matrix-js-sdk (ie. matrix-react-sdk/src/languageHandler.tsx)
  • Then we need to adapt the DecryptionError messages with i18n
    • In matrix-js-sdk/src/crypto/index.ts:
      • 'Unknown encryption algorithm "' + algorithm + '".'
    • In matrix-js-sdk/src/crypto/OlmDevice.ts:
      • adapt the method in calculateWithheldMessage to support i18n
    • In matrix-js-sdk/src/crypto/algorithms/megolm.ts:
      • "Missing fields in input"
      • "Unknown Error: Error is undefined"
      • " Trying to create a new secure channel and re-requesting the keys."
      • "The sender was unable to establish a secure channel."
      • "The secure channel with the sender was corrupted."
      • "The sender's device has not sent us the keys for this message."
      • "Message intended for room " + payload.room_id
    • In matrix-js-sdk/src/crypto/algorithms/olm.ts :
      • "Missing ciphertext"
      • "Not included in recipients"
      • "Bad Encrypted Message"
      • "Message was intented for " + payload.recipient
      • "Message not intended for this device"
      • "Message claimed to be from " + event.getSender()
      • "Message forwarded from " + payload.sender
      • "Message intended for room " + payload.room_id
@mcalinghee
Copy link
Contributor Author

We can close this issue as a re-work of the DecryptionError has been done in element : matrix-org/matrix-react-sdk#9544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant