fix(config): handle mixed relative and absolute paths

[smcgivern]

We need to call absolute() to convert a relative path to an absolute path before trying to compare parents, as parents is (per the docs), 'a purely lexical operation'.

Fixes #426.

[smcgivern]

I'm sure there's a better way to do this 😬

[smcgivern]

The failure on Windows was because resolve() can be confusing there (at least, it was to me). I think absolute() is fine for this case - see python/cpython#26153 - so let's see if that makes CI happy.

[smcgivern]

I'm assuming the coverage failure is because this PR is from a fork?

Error: you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag

[tconbeer]

I'm assuming the coverage failure is because this PR is from a fork?

Error: you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag

yes, don't worry about that one

[tconbeer]

@smcgivern Thanks so much for contributing!

[tconbeer]

This turned out to be the wrong solution; click resolves paths before passing them into cli.main, so the rest of the code doesn't need to handle relative paths for files. We just weren't handling the case where there are no common parents. This isn't possible on posix systems, but it is on Windows.

[smcgivern]

I am on macOS and sqlfmt foo $PWD/foo crashes without something like this, so I'm not sure paths are resolved going in. I mean, you can also try the test here without this change and see if it passes 😃

However, I see what you mean about click. You can set resolve_path (https://click.palletsprojects.com/en/8.1.x/api/#click.Path), but it defaults to off, and it doesn't look like it's set here?

sqlfmt/src/sqlfmt/cli.py

Line 158 in 96ed116

type=click.Path(exists=True, allow_dash=True, path_type=Path),