Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use anyhow #248

Closed
dbrgn opened this issue Jan 2, 2022 · 4 comments
Closed

Use anyhow #248

dbrgn opened this issue Jan 2, 2022 · 4 comments
Assignees
@dbrgn
Labels
chore
Milestone
v1.6.0

Comments

@dbrgn
Copy link
Collaborator

dbrgn commented Jan 2, 2022

Using anyhow instead of custom error types and strings is probably a good idea.

I started the work to port the codebase to anyhow.
@dbrgn dbrgn added the chore label Jan 2, 2022
@dbrgn dbrgn self-assigned this Jan 2, 2022
@dbrgn dbrgn added this to the v1.5.1 milestone Jan 2, 2022
@niklasmohrin
Copy link
Collaborator

Lets benchmark afterwards, I am curious

@dbrgn
Copy link
Collaborator Author

dbrgn commented Jan 2, 2022

What would you benchmark, the error branches? I don't think it should affect the success branches at all (and the error branches don't matter).

@niklasmohrin
Copy link
Collaborator

I don't think it should affect the success branches at all

I would expect that too, but I want to be sure 😅

@dbrgn
Copy link
Collaborator Author

dbrgn commented Jan 9, 2022

Fixed in #249.

@dbrgn dbrgn closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbrgn dbrgn

Labels
chore
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@dbrgn @niklasmohrin