Create cache directory path if it does not exist #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyDanny
force-pushed
the
create-cache-directory
branch
from
ddc9465
to
a1c16aa
Compare
niklasmohrin
requested changes
Apr 24, 2021
SimplyDanny
force-pushed
the
create-cache-directory
branch
from
a1c16aa
to
3a814ad
Compare
|
@dbrgn Any chance you can take a quick look at #174 (comment) so this can move forward? :^) |
dbrgn
added
the
ready-for-review
dbrgn
changed the title
dbrgn
added
waiting-for-author
SimplyDanny
force-pushed
the
create-cache-directory
branch
from
3a814ad
to
e96edc8
Compare
niklasmohrin
requested changes
Sep 9, 2021
SimplyDanny
force-pushed
the
create-cache-directory
branch
from
e96edc8
to
d7d3215
Compare
SimplyDanny
force-pushed
the
create-cache-directory
branch
from
d7d3215
to
eab70a9
Compare
niklasmohrin
approved these changes
Sep 12, 2021
niklasmohrin
added
ready-for-review
dbrgn
approved these changes
Sep 12, 2021
There was a problem hiding this comment.
Looks great now, thank you @SimplyDanny (and @niklasmohrin for the reviews)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve #167. If
TEALDEER_CACHE_DIRis set but does not exist, the complete path is just created as suggested in the issue. The user will be informed about the creation.