Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI modification #38

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

karthickgandhiTV
Copy link
Contributor

  1. Options has been replaced by Synchronization settings (Checkboxes aligned to the left from their current position)
  2. Test run checkbox replaced with a button.
  3. API token and scheduled sync moved to Settings page. (Earlier position : Fixed position at the bottom irrespective of tabs)
  4. Descriptions added to Synchronization, User settings, Authentication ,Scheduled Task and Logging.
  5. Groups checkbox has been moved to synchronization settings in the first tab.
  6. Scheduled Task interval textbox replaced with Combobox.
  7. Labels for Login Method changed

"AccountTypeGeneratedPassword": "Konten mit generiertem Passwort erstellen",
"AccountTypeSso": "Single Sign-On verwenden (benötigt Tensor Lizenz)",
"AccountTypeDefaultPassword": "Vorgegebenem Passwort:",
"AccountTypeGeneratedPassword": "Generiertem Passwort:",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"AccountTypeGeneratedPassword": "Generiertem Passwort:",
"AccountTypeGeneratedPassword": "Zufällig generiertes Passwort",

"AccountTypeDefaultPassword": "Konten mit vorgegebenem Passwort erstellen:",
"AccountTypeGeneratedPassword": "Konten mit generiertem Passwort erstellen",
"AccountTypeSso": "Single Sign-On verwenden (benötigt Tensor Lizenz)",
"AccountTypeDefaultPassword": "Vorgegebenem Passwort:",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"AccountTypeDefaultPassword": "Vorgegebenem Passwort:",
"AccountTypeDefaultPassword": "Vorgegebenes Passwort:",

@@ -144,6 +148,13 @@ function Invoke-GraphicalUserInterfaceConfiguration($configuration, [string] $cu
Content = $locale."UserLanguage_$_"
} })


$scheduledSyncIntervalsData = (Get-SupportedScheduledSyncIntervals | ForEach-Object {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is displayed as "sorted by string" in the GUI. Thus we offer them in this order:
16
24
4
8

Probably that is the default behavior of the list box control. Can we turn this off and use the insert order instead?

"AccountTypeSso": "Single Sign-On verwenden (benötigt Tensor Lizenz)",
"AccountTypeDefaultPassword": "Vorgegebenem Passwort:",
"AccountTypeGeneratedPassword": "Generiertem Passwort:",
"AccountTypeSso": "Single Sign-On(SSO):",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"AccountTypeSso": "Single Sign-On(SSO):",
"AccountTypeSso": "Single Sign-On(SSO)",

@stefanhubertus stefanhubertus merged commit 1705b6b into teamviewer:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants