From 81de5706cdf3ca799b08bad4a3de3169a1ca7379 Mon Sep 17 00:00:00 2001
From: Byungjin Park <posquit0.bj@gmail.com>
Date: Fri, 24 Feb 2023 15:06:38 +0900
Subject: [PATCH] Fix tflint failed code

---
 modules/elasticache-redis-cluster/README.md   | 2 +-
 modules/elasticache-redis-cluster/main.tf     | 2 +-
 modules/elasticache-redis-cluster/outputs.tf  | 2 +-
 modules/elasticache-redis-cluster/versions.tf | 2 +-
 modules/elasticache-redis-user/README.md      | 2 +-
 modules/elasticache-redis-user/variables.tf   | 4 ++--
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/elasticache-redis-cluster/README.md b/modules/elasticache-redis-cluster/README.md
index fefef57..f687272 100644
--- a/modules/elasticache-redis-cluster/README.md
+++ b/modules/elasticache-redis-cluster/README.md
@@ -13,7 +13,7 @@ This module creates following resources.
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3 |
-| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 4.30 |
+| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 4.36 |
 
 ## Providers
 
diff --git a/modules/elasticache-redis-cluster/main.tf b/modules/elasticache-redis-cluster/main.tf
index 1c94eff..13378e9 100644
--- a/modules/elasticache-redis-cluster/main.tf
+++ b/modules/elasticache-redis-cluster/main.tf
@@ -106,7 +106,7 @@ resource "aws_elasticache_replication_group" "this" {
   subnet_group_name           = var.subnet_group
   preferred_cache_cluster_azs = var.preferred_availability_zones
   security_group_ids = (var.default_security_group.enabled
-    ? concat(module.security_group.*.id, var.security_groups)
+    ? concat(module.security_group[*].id, var.security_groups)
     : var.security_groups
   )
 
diff --git a/modules/elasticache-redis-cluster/outputs.tf b/modules/elasticache-redis-cluster/outputs.tf
index b9ff469..b55d74c 100644
--- a/modules/elasticache-redis-cluster/outputs.tf
+++ b/modules/elasticache-redis-cluster/outputs.tf
@@ -65,7 +65,7 @@ output "network" {
     subnet_group                 = aws_elasticache_replication_group.this.subnet_group_name
     preferred_availability_zones = aws_elasticache_replication_group.this.preferred_cache_cluster_azs
 
-    default_security_group = one(module.security_group.*.id)
+    default_security_group = one(module.security_group[*].id)
     security_groups        = aws_elasticache_replication_group.this.security_group_ids
   }
 }
diff --git a/modules/elasticache-redis-cluster/versions.tf b/modules/elasticache-redis-cluster/versions.tf
index d55a08d..0c5a0cf 100644
--- a/modules/elasticache-redis-cluster/versions.tf
+++ b/modules/elasticache-redis-cluster/versions.tf
@@ -4,7 +4,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 4.30"
+      version = ">= 4.36"
     }
   }
 }
diff --git a/modules/elasticache-redis-user/README.md b/modules/elasticache-redis-user/README.md
index 68d9188..1d4d7e3 100644
--- a/modules/elasticache-redis-user/README.md
+++ b/modules/elasticache-redis-user/README.md
@@ -36,7 +36,7 @@ This module creates following resources.
 |------|-------------|------|---------|:--------:|
 | <a name="input_id"></a> [id](#input\_id) | (Required) The ID of the ElastiCache user. | `string` | n/a | yes |
 | <a name="input_name"></a> [name](#input\_name) | (Required) The username of the ElastiCache user. It can have up to 40 characters, and must begin with a letter. It should not end with a hyphen or contain two consecutive hyphens. Valid characters: A-Z, a-z, 0-9, and - (hyphen). | `string` | n/a | yes |
-| <a name="input_access_string"></a> [access\_string](#input\_access\_string) | (Optional) Access permissions string used for this user. | `string` | `""` | no |
+| <a name="input_access_string"></a> [access\_string](#input\_access\_string) | (Optional) Access permissions string used for this user. Defaults to `off -@all`. | `string` | `"off -@all"` | no |
 | <a name="input_module_tags_enabled"></a> [module\_tags\_enabled](#input\_module\_tags\_enabled) | (Optional) Whether to create AWS Resource Tags for the module informations. | `bool` | `true` | no |
 | <a name="input_password_required"></a> [password\_required](#input\_password\_required) | (Optional) Whether a password is required for this user. Defaults to `false`. | `bool` | `false` | no |
 | <a name="input_passwords"></a> [passwords](#input\_passwords) | (Optional) A set of passwords used for this user. You can create up to two passwords for each user. | `set(string)` | `[]` | no |
diff --git a/modules/elasticache-redis-user/variables.tf b/modules/elasticache-redis-user/variables.tf
index 286f1fa..fa285a4 100644
--- a/modules/elasticache-redis-user/variables.tf
+++ b/modules/elasticache-redis-user/variables.tf
@@ -12,9 +12,9 @@ variable "name" {
 
 # INFO: https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Clusters.RBAC.html#Access-string
 variable "access_string" {
-  description = "(Optional) Access permissions string used for this user."
+  description = "(Optional) Access permissions string used for this user. Defaults to `off -@all`."
   type        = string
-  default     = ""
+  default     = "off -@all"
   nullable    = false
 }