Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble with saving nodes created with capture templates. #10

Closed
andersjohansson opened this issue Jan 10, 2022 · 4 comments
Closed

Trouble with saving nodes created with capture templates. #10

andersjohansson opened this issue Jan 10, 2022 · 4 comments

Comments

@andersjohansson
Copy link

Using the default org-roam-capture-templates and calling org-roam-node-find, an org capture buffer is opened, but is not yet saved to a file. On saving (save-buffer) or finishing the capture (C-c C-c), org-roam-timestamps--on-save is called but encounters problems.

I get "( wrong-type-argument number-or-marker-p nil)" as for #7, and this is in org-roam-timestamps--add-ctime.

The buffer registers as an org-roam buffer, but the org-roam-node-at-point returns a fairly empty struct with only :id and :point set. When org-roam-timestamps--add-ctime, we don’t have a level so the check (= 0 level) errors out.

Is this a problem with org-roam (should we have more info for the current node already?) or org-roam-timestamps assuming that this information should be available when it is not?

@tefkah
Copy link
Owner

tefkah commented Jan 11, 2022

I've been having this issue as well, it's probably something to do with org-roam-timestamps. I don't have a lot of time to debug this at the moment, but I will fix it eventually!

@tefkah
Copy link
Owner

tefkah commented Jan 11, 2022

Actually that was a super simple fix, thanks for pointing out the problem!

@tefkah
Copy link
Owner

tefkah commented Jan 11, 2022

I will close this for now, feel free to open it back up if it's still broken!

@tefkah tefkah closed this as completed Jan 11, 2022
@andersjohansson
Copy link
Author

Trying it out and it seems to work, but it seems to still be only on the merge branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants