Test GCS Tasks #262
Test GCS Tasks #262
Conversation
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/L
gcs/tests/gcs-sample.yaml
Outdated
| #!/usr/bin/env bash | ||
| set -xe | ||
| mkdir -p $(workspaces.data.path)/$(uid)/cookies/ | ||
| echo "Test data $(uid)" > $(workspaces.data.path)/$(uid)/cookies/recipe |
There was a problem hiding this comment.
put a recipe in the recipe file or call the file something different.
There was a problem hiding this comment.
now i suddenly want to create something called "tekton recipes"
looks like the existing tests try to apply all the yamls which wont work for the triggers types (yet!) |
gcs/tests/gcs-sample.yaml
Outdated
| - name: output | ||
| workspace: data | ||
| params: | ||
| - name: name |
There was a problem hiding this comment.
oh whoops, this should be path now i think!
|
I've renamed the |
|
/test pull-tekton-catalog-integration-tests |
gcs/sample/gcs-sample.yaml
Outdated
| - name: pvc-name | ||
| - name: project-name | ||
| - name: secret-name | ||
| resourceTemplates: |
There was a problem hiding this comment.
this should actually be resourcetemplates - long story regarding how we got away with this but working with @dibyom it looks like this might be the root of tektoncd/triggers#526
There was a problem hiding this comment.
👍 replaced resourceTemplates with resourcetemplates
Tasks in the catalog don't currently have a uniform approach to testing. It would be good if the catalog provided some kind of blessed path and supporting infrastructure so that Tasks can be exercised as part of PRs. This commit includes a test for the GCS tasks that utilizes triggers to kick off a pipelinerun. There are still some decisions to be made around how service account generation might work, how the needed infra gets spun up, and how the triggers get _triggered_ in the first place, but this demonstrates the general idea. coauthored with @sbwsg
ghost
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Tasks in the catalog don't currently have a uniform approach to testing. It would be good if the catalog provided some kind of blessed path and supporting infrastructure so that Tasks can be exercised as part of PRs.
This commit includes a test for the GCS tasks that utilizes triggers to kick off a pipelinerun. There are still some decisions to be made around how service account generation might work, how the needed infra gets spun up, and how the triggers get triggered in the first place, but this demonstrates the general idea.
author: @bobcatfish
coauthor: @sbwsg
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.