From a25d288ffab229b98be2e10cc3e7feb9a3f338b3 Mon Sep 17 00:00:00 2001 From: Vibhav Bobade Date: Mon, 24 Feb 2020 23:42:02 +0530 Subject: [PATCH] Remove -t timeout shorthand from tkn task start fixes https://github.com/tektoncd/cli/issues/743 --- docs/cmd/tkn_task_start.md | 2 +- docs/man/man1/tkn-task-start.1 | 2 +- pkg/cmd/task/start.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/cmd/tkn_task_start.md b/docs/cmd/tkn_task_start.md index abf0a169a..250a2d30b 100644 --- a/docs/cmd/tkn_task_start.md +++ b/docs/cmd/tkn_task_start.md @@ -40,7 +40,7 @@ like cat,foo,bar --prefix-name string specify a prefix for the taskrun name (must be lowercase alphanumeric characters) -s, --serviceaccount string pass the serviceaccount name --showlog show logs right after starting the task - -t, --timeout int timeout for taskrun in seconds (default 3600) + --timeout int timeout for taskrun in seconds (default 3600) --use-taskrun string specify a taskrun name to use its values to re-run the taskrun ``` diff --git a/docs/man/man1/tkn-task-start.1 b/docs/man/man1/tkn-task-start.1 index d847a4022..0f7495847 100644 --- a/docs/man/man1/tkn-task-start.1 +++ b/docs/man/man1/tkn-task-start.1 @@ -68,7 +68,7 @@ Start tasks show logs right after starting the task .PP -\fB\-t\fP, \fB\-\-timeout\fP=3600 +\fB\-\-timeout\fP=3600 timeout for taskrun in seconds .PP diff --git a/pkg/cmd/task/start.go b/pkg/cmd/task/start.go index 4486103b1..65700fdf4 100644 --- a/pkg/cmd/task/start.go +++ b/pkg/cmd/task/start.go @@ -156,7 +156,7 @@ like cat,foo,bar c.Flags().StringSliceVarP(&opt.Labels, "labels", "l", []string{}, "pass labels as label=value.") c.Flags().BoolVarP(&opt.ShowLog, "showlog", "", false, "show logs right after starting the task") c.Flags().StringVarP(&opt.Filename, "filename", "f", "", "local or remote file name containing a task definition") - c.Flags().Int64VarP(&opt.TimeOut, "timeout", "t", 3600, "timeout for taskrun in seconds") + c.Flags().Int64VarP(&opt.TimeOut, "timeout", "", 3600, "timeout for taskrun in seconds") c.Flags().BoolVarP(&opt.DryRun, "dry-run", "", false, "preview taskrun without running it") c.Flags().StringVarP(&opt.Output, "output", "", "", "format of taskrun dry-run (yaml or json)") c.Flags().StringVarP(&opt.PrefixName, "prefix-name", "", "", "specify a prefix for the taskrun name (must be lowercase alphanumeric characters)")