Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest knative.dev/pkg adds support for conversion webhooks #2047

Closed
mattmoor opened this issue Feb 13, 2020 · 4 comments · Fixed by #2413
Closed

Latest knative.dev/pkg adds support for conversion webhooks #2047

mattmoor opened this issue Feb 13, 2020 · 4 comments · Fixed by #2413
Assignees
Labels
area/dependency Issues or PRs related to dependency changes area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic)

Comments

@mattmoor
Copy link
Member

This is at HEAD and will be in 0.13.

cc @vdemeester

@vdemeester vdemeester added the area/dependency Issues or PRs related to dependency changes label Feb 14, 2020
@vdemeester
Copy link
Member

/assign

@bobcatfish
Copy link
Collaborator

Status: we have bumped, but we haven't yet updated our webhooks yet.

@bobcatfish bobcatfish modified the milestones: Pipelines 1.0/beta 🐱, Pipelines 1.1 / Post-beta 🐱 Mar 16, 2020
@vdemeester vdemeester modified the milestones: Pipelines Post-beta 🐱, Pipelines 0.12 🐱 Apr 6, 2020
@vdemeester vdemeester added the area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) label Apr 16, 2020
@riceluxs1t
Copy link

This may not be the best place to ask but @vdemeester could you point me to a link that describes what conversion web hook does? I have some code that creates a simple PipelineRun object that explicitly specifies its apiVersion to be v1beta1 but when I use a Dynamic client (or Tekton client) to ask "give me all the PipelineRuns of apiVersion v1alpha1, the client returns the pipeline run I created (I expect no pipeline run to be returned). The opposite also seems to happen ; that is, I create a PR with apiVersion equal to v1alpha and ask "give me all PRs with apiVrsion = v1beta, I get back the PR (and I don't expect to)

@mattmoor
Copy link
Member Author

When an API serves multiple versions, e.g. v1alpha1 and v1beta1, resources exist at all versions.

Without conversion webhooks, what you'd see is the exact same resource being returned with different TypeMeta (e.g. you'd get the v1alpha1 or v1beta1 that you asked for).

Conversion webhooks let us change the schema of resources across versions, so if fields move between alpha and beta we can return them in the appropriate place based on the version at which folks are asking for them.

So don't think "I created a v1beta1 PipelineRun", but "I created a PipelineRun, using a v1beta1 schema".

Hopefully that makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants