-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Generate validate OpenAPIV3Schema 🏫 #1776
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This uses `controller-gen` to generate validation schema for our CRDs. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
be46bd9
to
23a82ec
Compare
@vdemeester: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@vdemeester checking in here, is the intention to continue working on this PR? Are you blocked on something specific like the v1alpha2 work? |
This is gonna need a huge rework I feel, so… closing it for now (again 😛 ) |
Changes
This uses
controller-gen
to generate validation schema for our CRDs.There is a few issue to fix before considering this ready.
go install …
failed because of dependencies, … which is a bit a shame…This carry on #1179 👼
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes