From 309fd474775fe2d6f8c232047efc2f3d37c5a1d0 Mon Sep 17 00:00:00 2001 From: Vincent Demeester Date: Wed, 8 Sep 2021 11:35:48 +0200 Subject: [PATCH] =?UTF-8?q?Skipping=20the=20CI=20secret=20sauce=20?= =?UTF-8?q?=F0=9F=A6=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is skipping tests that depends on the build-crd GCP project that got deleted recently. This will unblock CI while we replace this with using our own GCP project (or a better way) Signed-off-by: Vincent Demeester --- examples/v1alpha1/taskruns/{ => no-ci}/docker-creds.yaml | 0 examples/v1alpha1/taskruns/{ => no-ci}/pull-private-image.yaml | 0 examples/v1beta1/taskruns/{ => no-ci}/docker-creds.yaml | 0 examples/v1beta1/taskruns/{ => no-ci}/pull-private-image.yaml | 0 internal/builder/v1beta1/pod.go | 1 + test/pipelinerun_test.go | 2 ++ test/v1alpha1/pipelinerun_test.go | 1 + 7 files changed, 4 insertions(+) rename examples/v1alpha1/taskruns/{ => no-ci}/docker-creds.yaml (100%) rename examples/v1alpha1/taskruns/{ => no-ci}/pull-private-image.yaml (100%) rename examples/v1beta1/taskruns/{ => no-ci}/docker-creds.yaml (100%) rename examples/v1beta1/taskruns/{ => no-ci}/pull-private-image.yaml (100%) diff --git a/examples/v1alpha1/taskruns/docker-creds.yaml b/examples/v1alpha1/taskruns/no-ci/docker-creds.yaml similarity index 100% rename from examples/v1alpha1/taskruns/docker-creds.yaml rename to examples/v1alpha1/taskruns/no-ci/docker-creds.yaml diff --git a/examples/v1alpha1/taskruns/pull-private-image.yaml b/examples/v1alpha1/taskruns/no-ci/pull-private-image.yaml similarity index 100% rename from examples/v1alpha1/taskruns/pull-private-image.yaml rename to examples/v1alpha1/taskruns/no-ci/pull-private-image.yaml diff --git a/examples/v1beta1/taskruns/docker-creds.yaml b/examples/v1beta1/taskruns/no-ci/docker-creds.yaml similarity index 100% rename from examples/v1beta1/taskruns/docker-creds.yaml rename to examples/v1beta1/taskruns/no-ci/docker-creds.yaml diff --git a/examples/v1beta1/taskruns/pull-private-image.yaml b/examples/v1beta1/taskruns/no-ci/pull-private-image.yaml similarity index 100% rename from examples/v1beta1/taskruns/pull-private-image.yaml rename to examples/v1beta1/taskruns/no-ci/pull-private-image.yaml diff --git a/internal/builder/v1beta1/pod.go b/internal/builder/v1beta1/pod.go index dd04195cf64..52ec13a0379 100644 --- a/internal/builder/v1beta1/pod.go +++ b/internal/builder/v1beta1/pod.go @@ -12,6 +12,7 @@ distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + */ package builder diff --git a/test/pipelinerun_test.go b/test/pipelinerun_test.go index 2a371e95eb5..c377dcfb623 100644 --- a/test/pipelinerun_test.go +++ b/test/pipelinerun_test.go @@ -91,6 +91,7 @@ func TestPipelineRun(t *testing.T) { name: "service account propagation and pipeline param", testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) { t.Helper() + t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping") if _, err := c.KubeClient.CoreV1().Secrets(namespace).Create(ctx, getPipelineRunSecret(index, namespace), metav1.CreateOptions{}); err != nil { t.Fatalf("Failed to create secret `%s`: %s", getName(secretName, index), err) } @@ -163,6 +164,7 @@ func TestPipelineRun(t *testing.T) { name: "pipelinerun succeeds with LimitRange minimum in namespace", testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) { t.Helper() + t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping") if _, err := c.KubeClient.CoreV1().LimitRanges(namespace).Create(ctx, getLimitRange("prlimitrange", namespace, "100m", "99Mi", "100m"), metav1.CreateOptions{}); err != nil { t.Fatalf("Failed to create LimitRange `%s`: %s", "prlimitrange", err) } diff --git a/test/v1alpha1/pipelinerun_test.go b/test/v1alpha1/pipelinerun_test.go index bb3d1eaf594..b0f7995eea2 100644 --- a/test/v1alpha1/pipelinerun_test.go +++ b/test/v1alpha1/pipelinerun_test.go @@ -88,6 +88,7 @@ func TestPipelineRun(t *testing.T) { name: "service account propagation and pipeline param", testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) { t.Helper() + t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping") if _, err := c.KubeClient.CoreV1().Secrets(namespace).Create(ctx, getPipelineRunSecret(index), metav1.CreateOptions{}); err != nil { t.Fatalf("Failed to create secret `%s`: %s", getName(secretName, index), err) }