Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerBinding doesn't support params of Array type #545

Closed
savitaashture opened this issue Apr 20, 2020 · 2 comments
Closed

TriggerBinding doesn't support params of Array type #545

savitaashture opened this issue Apr 20, 2020 · 2 comments

Comments

@savitaashture
Copy link
Contributor

Expected Behavior

TriggerBinding should not expect params of array type

Actual Behavior

TriggerBinding allow user to provide params of array type

Steps to Reproduce the Problem

  1. Create a triggerbinding by providing params with array type
  2. TriggerBinding create successfully

Additional Info

For more info #543 (comment) , #543 (comment)

@dibyom
Copy link
Member

dibyom commented Apr 21, 2020

From the WG today, we decided that we'll keep Params in bindings to only strings for now. In #532, we'll start using our own Param types that only have string values so there should be any confusion!

/close

@tekton-robot
Copy link

@dibyom: Closing this issue.

In response to this:

From the WG today, we decided that we'll keep Params in bindings to only strings for now. In #532, we'll start using our own Param types that only have string values so there should be any confusion!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants