Added URL field to WebhookInterceptor

[mpetason]

Changes

Added URL field to WebhookInterceptor in trigger_types

Fixes #270

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Added URL field to WebhookInterceptor

[tekton-robot]

Hi @mpetason. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dibyom]

/ok-to-test

[afrittoli]

@mpetason Thank you for this PR!
You will need a release notes section in the PR body.

[dibyom]

Thanks @mpetason

1We should also ensure that this new field can be used to resolve the Webhook URL i.e. if the URL field is present we should use that instead of trying to resolve using the Service name. The change should be around here: https://github.com/tektoncd/triggers/blob/main/pkg/interceptors/webhook/webhook.go#L88

[mpetason]

Thanks for the update. I'll take a look and see if I can fix that and submit an update to the PR.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_types.go	Do not exist	100.0%
pkg/interceptors/webhook/webhook.go	89.7%	90.3%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_types.go	Do not exist	100.0%
pkg/interceptors/webhook/webhook.go	89.7%	90.0%	0.3

[mpetason]

/test pull-tekton-triggers-integration-tests

[dibyom]

Nice. Thanks @mpetason One small thing - could you please squash up the commits into one? Otherwise good to go/

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/webhook/webhook.go	89.7%	90.0%	0.3

[dibyom]

/lgtm

[mpetason]

I think some of the tests are stuck, maybe I don't have permissions to force a retest on all? It doesn't look like /test or /retest triggered it. When I look at "Details" it doesn't link to anything valid.

[mpetason]

/retest