Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the Triggers tutorial for clarity and flow #1018

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Rewrite the Triggers tutorial for clarity and flow #1018

merged 1 commit into from
Mar 31, 2021

Conversation

tualeron
Copy link
Contributor

Changes

Rewrites the Triggers tutorial for clarity and flow.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 25, 2021
@tekton-robot tekton-robot requested review from vtereso and wlynch March 25, 2021 21:10
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2021
@tualeron
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 25, 2021
@tualeron
Copy link
Contributor Author

/assign @dibyom

dibyom
dibyom reviewed Mar 29, 2021
View reviewed changes
docs/getting-started/README.md Outdated Show resolved Hide resolved
docs/getting-started/README.md Outdated Show resolved Hide resolved
mpetason
mpetason reviewed Mar 30, 2021
View reviewed changes
Copy link
Contributor

@mpetason mpetason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling fix

docs/getting-started/README.md Outdated Show resolved Hide resolved
dibyom
dibyom reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Just one other place I noticed we could be clearer.

docs/getting-started/README.md Outdated Show resolved Hide resolved
docs/getting-started/README.md Outdated Show resolved Hide resolved
@tualeron
Rewrite the Triggers tutorial for clarity and flow
9361cfa 
Rewrites the Triggers tutorial for clarity and flow
@tekton-robot
Copy link

tekton-robot commented Mar 31, 2021 •
edited
Loading

@sergetron: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-triggers-unit-tests 9361cfa link /test tekton-triggers-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tualeron
Copy link
Contributor Author

/retest

@tualeron
Copy link
Contributor Author

tualeron commented Mar 31, 2021 •
edited
Loading

Thank you for the thorough reviews Savita, Mike, and Dibyo! Can we have LGTM?

dibyom
dibyom approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@tekton-robot tekton-robot merged commit 0adb610 into tektoncd:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@mpetason mpetason mpetason left review comments

@dibyom dibyom dibyom approved these changes

@vtereso vtereso Awaiting requested review from vtereso

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tualeron @tekton-robot @mpetason @dibyom @savitaashture