Fixes Triggers release pipeline and tasks #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
nikhil-thomas
force-pushed
the
update/release-pipelines
branch
2 times, most recently
from
5be5dd5 to
3e621e8
Compare
Fix `ko resolve` step in `publish-tekton-triggers` task Fix `koparse` error ``` Expected images did not match: Images ['gcr.io/tekton-nightly/github.com/tektoncd/triggers/cmd/binding-eval:v20210331-6cc9094a8a', 'gcr.io/tekton-nightly/github.com/tektoncd/triggers/cmd/triggerrun:v20210331-6cc9094a8a', 'gcr.io/tekton-nightly/github.com/tektoncd/triggers/cmd/interceptors:v20210331-6cc9094a8a'] were expected but missing. ``` Tested by running a nightly release: https://dashboard.dogfooding.tekton.dev/#/namespaces/tekton-nightly/pipelineruns/triggers-release-nightly-vp46d?pipelineTask=git-clone&step=clone Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
update/release-pipelines
branch
from
3e621e8 to
190b396
Compare
|
/retest |
|
/test pull-tekton-triggers-build-tests |
|
Not sure what is going on with the build tests. |
|
its odd because the test logs don't show any errors...i had the same thing happen on the other PR I submitted this morning |
|
I guess prow must have been running into issues. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ko resolvestep inpublish-tekton-triggerstaskFix
koparseerrorRename release pipeline to
releaseinstead oftriggers-releaseaskustomization in plumbing will add the
triggers-prefix while updating thepipeline on dogfooding cluster (namespace: tekton-nigtly), every hour.
Without this patch the name of the Triggers release pipeline created on dogfooding cluster
will be
triggers-triggers-release.Note: The TriggerTemplate refers to pipelineref:
triggers-release.ref: https://github.com/tektoncd/plumbing/blob/9dcf14d1320bd10674d44673cebac8ecc6bae30e/tekton/resources/nightly-release/overlays/triggers/kustomization.yaml#L1
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes