Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving file read issue with binding-eval #1039

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

jmcshane
Copy link
Contributor

@jmcshane jmcshane commented Apr 9, 2021

Changes

This aligns the way that trigger eval parses the HTTP request file with the way that the
triggerrun binary operates. The file closing before reading the HTTP request body does
not work properly, so we have to do all of that within a single function

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

Resolves #955

This aligns the way that trigger eval parses the HTTP request file with the way that the
triggerrun binary operates. The file closing before reading the HTTP request body does
not work properly, so we have to do all of that within a single function
@tekton-robot tekton-robot requested review from khrm and wlynch April 9, 2021 20:03
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2021
@jmcshane jmcshane changed the title Resolving issue with binding-eval Resolving file read issue with binding-eval Apr 9, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/binding-eval/cmd/root.go 75.5% 75.0% -0.5

@dibyom
Copy link
Member

dibyom commented Apr 12, 2021

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@tekton-robot tekton-robot merged commit 6ea31d9 into tektoncd:main Apr 12, 2021
@jmcshane jmcshane deleted the bugfix/binding-eval-body branch April 12, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binding-eval error reading HTTP body: read http.txt: file already closed
3 participants