Removing deprecated fields

[jmcshane]

Changes

Closes #904

This PR removes the deprecated ServiceType and PodTemplate fields from the EventListener Spec

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Removes deprecated API fields from EventListener spec

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.0%	-0.8
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	79.5%	78.4%	-1.1
test/builder/eventlistener.go	81.5%	71.6%	-9.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.0%	-0.8
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	79.5%	78.4%	-1.1
test/builder/eventlistener.go	81.5%	78.8%	-2.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.0%	-0.8
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	79.5%	78.4%	-1.1
test/builder/eventlistener.go	81.5%	78.8%	-2.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
test/builder/eventlistener.go	81.5%	78.8%	-2.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
test/builder/eventlistener.go	81.5%	91.5%	9.9

[jmcshane]

The reduction in test coverage in the defaults package is due to the removal of code that was covered at 100% (higher than the rest of the file). Any other test changes made in this PR would be unrelated to the removal of the deprecated fields.

[jmcshane]

The only thing I see left here is if we want to call out the kubernetesResource.serviceType field explicitly as a way to expose event listener in the exposing-eventlisteners.md document. This document did not have the deprecated ServiceType field called out, but it was called out in a couple of the examples. Besides that, this was a straightforward removal of the two removed fields.

[jmcshane]

/test pull-tekton-triggers-build-tests

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
test/builder/eventlistener.go	81.5%	91.5%	9.9

[jmcshane]

/assign @iancoffey

[dibyom]

This LGTM. We should decide which release we are intending to remove these fields.

[iancoffey]

/lgtm , pending release decision

[dibyom]

I think this can make it to the v0.14 release.

Just needs a rebase and then good to go.
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
test/builder/eventlistener.go	81.5%	91.5%	9.9

[jmcshane]

this PR should be good to go now for the release. everything has been cleaned up.

Should we write a document specific to migrating to this version given the removal of these fields?

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
test/builder/eventlistener.go	81.5%	91.5%	9.9

[jmcshane]

/test pull-tekton-triggers-go-coverage

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
test/builder/eventlistener.go	81.5%	91.5%	9.9

[jmcshane]

/test pull-tekton-triggers-go-coverage

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	95.0%	91.3%	-3.7
test/builder/eventlistener.go	81.5%	91.5%	9.9

[dibyom]

/lgtm