Raise the resync period to something more reasonable. #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 30s resync period is an unfortunate anti-pattern perpetuated by `k8s.io/sample-controller`, which has historically: * Masked bugs due to a missing informer event (hidden in e2e tests by the frequent "resync"), * Leads to problems at scale (lots of resources) because 30s is inadequate to process all resources continuously. The `controller.DefaultResyncPeriod` is `10h` adopted from controller-runtime, and the main motivation for using anything lower than this would be if it were necessary to poll an external system not modeled by informers, where the resync period effectively becomes a ceiling on the poll interval.
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XS
|
I'm opening this in isolation to let CI tell me if/what breaks from this, since whenever I see this there are invariably latent bugs masked by it. 😅 |
|
/assign @dibyom @savitaashture |
savitaashture
approved these changes
Aug 30, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 30s resync period is an unfortunate anti-pattern perpetuated by
k8s.io/sample-controller, which has historically:The
controller.DefaultResyncPeriodis10hadopted from controller-runtime, and the main motivation for usinganything lower than this would be if it were necessary to poll an external system not modeled by informers, where
the resync period effectively becomes a ceiling on the poll interval.
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes