-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eldeployment: remove securityContext.runAsUser #1213
eldeployment: remove securityContext.runAsUser #1213
Conversation
Hi @zhouhaibing089. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/cc @khrm |
Indeed. Because of this, we do patch this on release on OpenShift. Removing this would remove one of our patch 🙃 . I think it predates |
Yep I mentioned consistency with the other repos in the slack conversation around this that occurred (last week I believe) |
The setting on `securityContext.runAsUser` is redundant. The container runtime determines which user to run based on image config and thus uses 65532 by default. Furthermore, some kubernetes distributions randomizes runAsUser id according to their security policies(for e.g, openshift enables per application uid range), and when that happens, the uid can be set to something else.
7155c0f
to
ef7bb64
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The setting on
securityContext.runAsUser
is redundant. The containerruntime determines which user to run based on image config and thus uses
65532 by default.
Furthermore, some kubernetes distributions randomizes runAsUser id
according to their security policies(for e.g, openshift enables per
application uid range), and when that happens, the uid can be set to
something else.
See
config.User
on its default configuration.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes