Upgrading Go to 1.19 #1554
Upgrading Go to 1.19 #1554
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XXL
| @@ -601,7 +602,7 @@ func (c *Client) Do(req *Request) (*http.Response, error) { | |||
| if c, ok := body.(io.ReadCloser); ok { | |||
| req.Body = c | |||
| } else { | |||
| req.Body = io.NopCloser(body) | |||
| req.Body = ioutil.NopCloser(body) | |||
There was a problem hiding this comment.
An update to go1.19 shouldn't change this. Any idea why this happened? Also, why do we need go code here?
There was a problem hiding this comment.
(the go code is due to the license terms of the particular library I think)
tekton-robot
added
the
needs-rebase
|
@khrm I think we can just get rid of third_party similar to tektoncd/pipeline#6416 |
Our CI uses go1.19. Also, 1.18 is EOL.
tekton-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Our CI uses go1.19. Also, 1.18 is EOL.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes