Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string translation to CEL interceptor. #1686

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add string translation to CEL interceptor. #1686

merged 1 commit into from
Feb 6, 2024

Conversation

bigkevmcd
Copy link
Member

@bigkevmcd bigkevmcd commented Jan 31, 2024 •
edited
Loading

Changes

This adds a new "translate" function to the CEL interceptor library that allows using a regular expression to translate replacement characters to specified strings.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

New `translate` function added to the CEL interceptor.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 31, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2024
@bigkevmcd
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 31, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 89.7% 88.2% -1.5

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
khrm
khrm reviewed Feb 2, 2024
View reviewed changes
pkg/interceptors/cel/cel_test.go Outdated
@@ -278,7 +291,7 @@ func TestInterceptor_Process(t *testing.T) {
if tt.wantExtensions != nil {
got := res.Extensions
if diff := cmp.Diff(tt.wantExtensions, got); diff != "" {
rt.Fatalf("cel.Process() did return correct extensions (-wantMsg+got): %v", diff)
rt.Fatalf("cel.Process() did rnot eturn correct extensions (-wantMsg+got): %v", diff)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: did not return.

khrm
khrm reviewed Feb 2, 2024
View reviewed changes
docs/cel_expressions.md Outdated
translate()
</th>
<td>
<pre>&lt;string&gt;.translatet(string, string) -> &lt;string&gt;</pre>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
Shouldn't it be translate ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khrm

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 89.7% 88.2% -1.5

@savitaashture
Copy link
Contributor

@bigkevmcd can you rebase the PR

@bigkevmcd
Add string translation to CEL interceptor.
d4454ef 
This adds a new "translate" function to the CEL interceptor library that
allows using a regular expression to translate replacement characters to
specified strings.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 89.7% 88.2% -1.5

khrm
khrm reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@tekton-robot tekton-robot merged commit c7c5a8b into tektoncd:main Feb 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@savitaashture savitaashture savitaashture approved these changes

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigkevmcd @tekton-robot @savitaashture @khrm