Allow brackets inside Tekton expressions #375
Conversation
tekton-robot
added
the
do-not-merge/work-in-progress
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
size/S
We were previously using a regex to extract expressions within TriggerBindings. The regex only extracted between the initial `$(` and the first occurrence of the `)`. This meant that some valid JSONPath expressions that contained brackets (e.g. filters) were incorrectly extracted. This commit fixes the issue by splitting the string on `$(` and then extracting until the *last* occurrence of `)`. Fixes tektoncd#365 Co-Authored-By: Andrea Frittoli <andrea.frittoli@gmail.com> Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot
added
size/M
tekton-robot
removed
the
do-not-merge/work-in-progress
|
@dibyom: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Changes
We were previously using a regex to extract expressions within
TriggerBindings. The regex only extracted between the initial
$(and the first occurrence of the
). This meant that some validJSONPath expressions that contained brackets (e.g. filters) were
incorrectly extracted.
This commit fixes the issue by splitting the string on
$(and thenextracting until the last occurrence of
).Fixes #365
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes