Fix e2e tests #401
Merged
Fix e2e tests #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XS
khrm
reviewed
Jan 30, 2020
Fix the url of pipeline release.yaml as it was pointing to old release urls and was installing 0.7 till now, as 0.10.1 got released to both url's today, tests started failing So better fetch the latest release yaml from last release on github
tekton-robot
added
size/S
dibyom
approved these changes
Jan 30, 2020
| @@ -23,11 +23,23 @@ | |||
|
|
|||
| # Helper functions for E2E tests. | |||
|
|
|||
| # Check if we have a specific RELEASE_YAML global environment variable to use | |||
| # instead of detecting the latest released one from tektoncd/pipeline releases | |||
| RELEASE_YAML=${RELEASE_YAML:-} | |||
There was a problem hiding this comment.
Nice! Would you mind adding an example in the test README on how to use a specific release?
There was a problem hiding this comment.
Follow up PR should be fine for this 😄
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the url of pipeline release.yaml as it was pointing to old
release urls and was installing 0.7 till now, as 0.10.1 got released to
both url's today, tests started failing
So better fetch the latest release yaml from last release on github
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.