Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper function to triggerbinding in order to support params of type array #543

Closed
wants to merge 1 commit into from

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Apr 18, 2020

Changes

Add helper function to triggerbinding to support params of type array

Background:
Need to add test case for triggerbinding describe and did not find helper function for params fo Array type

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign iancoffey
You can assign the PR to them by writing /assign @iancoffey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2020
@khrm
Copy link
Contributor

khrm commented Apr 20, 2020

@savitaashture We don't support Array types of param in TriggerBindings for now.
Maybe we can create an issue and discuss.

@dibyom
Copy link
Member

dibyom commented Apr 20, 2020

+1 to @khrm We don't use the array param types and as part of #415 I'm thinking of making this clearer by having our own Param type that only supports strings.

@savitaashture
Copy link
Contributor Author

Thank you @khrm for confirming this
+1 to @dibyom we can anyway add own params
Created issue in order to address

We can discuss more in tomorrow's WG call so that i can proceed with the implementation

@dibyom
Copy link
Member

dibyom commented Apr 21, 2020

From the WG today, we decided that we'll keep Params in bindings to only strings for now. In #532, we'll start using our own Param types that only have string values so there should be any confusion!

Thanks @savitaashture . I'll close this PR for now!
/close

@tekton-robot
Copy link

@dibyom: Closed this PR.

In response to this:

From the WG today, we decided that we'll keep Params in bindings to only strings for now. In #532, we'll start using our own Param types that only have string values so there should be any confusion!

Thanks @savitaashture . I'll close this PR for now!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants