-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CEL function to parse YAML #636
Conversation
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also test/document behavior for nested types, since this came up with JSON support as well.
/cc @bigkevmcd
But otherwise LGTM! Thanks for the contribution! :) |
Both the JSON parsing and YAML parsing end up going through the same marshaling into the output JSON. Any differences should (theoretically) be down to the parsers themselves (ints/floats/strings/maps etc). |
/lgtm |
Added a CEL function named parseYAML that can parse an YAML string into a map of strings to dynamic values Syntax: <string>.parseYAML() -> map<string, dyn>
The following is the coverage report on the affected files.
|
/lgtm |
/approved |
Thanks @chetan-rns ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This PR will add a CEL function named
parseYAML
that can parse a YAML string into a map of strings to dynamic valuesSyntax: .parseYAML() -> map<string, dyn>
Fixes: #622
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes