Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass url through #657

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

bigkevmcd
Copy link
Member

Changes

Fix a bug in the sink where is not passing the URL through to the incoming requests.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Add the incoming request URL to the request passed through to interceptors.

@tekton-robot tekton-robot requested review from bobcatfish and dibyom July 2, 2020 16:27
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2020
This fixes an issue in the sink where it is not passing the URL through from the incoming request.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 74.5% 75.5% 1.0

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 74.5% 75.5% 1.0

@dibyom
Copy link
Member

dibyom commented Jul 6, 2020

Question: The WebhookInterceptor still won't have access to the URL right?

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@bigkevmcd
Copy link
Member Author

Question: The WebhookInterceptor still won't have access to the URL right?

We could add it as a Request header?

@dibyom
Copy link
Member

dibyom commented Jul 8, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@tekton-robot tekton-robot merged commit b386548 into tektoncd:master Jul 8, 2020
@bigkevmcd bigkevmcd deleted the pass-url-through branch September 24, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants