Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pipeline v0.13.2, knative 0.15 #661

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Update to pipeline v0.13.2, knative 0.15 #661

merged 1 commit into from
Jul 8, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jul 6, 2020 •
edited
Loading

Changes

The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts and remove some old pinned dependencies, and drop some deprecated functions and flags.

Needed for #635 and fixes #627

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 6, 2020
@tekton-robot tekton-robot requested review from iancoffey and ncskier July 6, 2020 18:44
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 6, 2020
@dibyom dibyom force-pushed the update-deps branch 5 times, most recently from d59ef93 to 48d1bce Compare July 7, 2020 02:43
vdemeester
vdemeester reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@dibyom
Copy link
Member Author

dibyom commented Jul 7, 2020

The webhook certs are not being created for some reason 🤔

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@dibyom dibyom mentioned this pull request Jul 7, 2020
Merged
3 tasks
@dibyom
Copy link
Member Author

dibyom commented Jul 7, 2020

The unit test passes locally...not sure what's going on 🤷

@vdemeester
Copy link
Member 

    TestInterceptor_ExecuteTrigger/handling_a_list_response: cel_test.go:248: Interceptor.ExecuteTrigger (-want, +got) =   []uint8{
          	... // 16 identical elements
          	0x22,
          	0x2c,
        - 	0x20,
          	0x22,
          	0x61,
          	... // 9 identical elements
          }

🤔

@dibyom
Update to use knative 0.15
740d80f 
The update to knative is to pick up genreconciler and in turn requires us to
update our pipelines dependency to v0.13.2. I had to update the hack/ scripts,
remove some old pinned dependencies, and drop some deprecated functions and
flags. To get the webhook cert generation to work again, I had to replace
`sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`.

Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom requested a review from vdemeester July 8, 2020 15:24
vdemeester
vdemeester reviewed Jul 8, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
wlynch
wlynch approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@tekton-robot tekton-robot merged commit 7fc96c7 into tektoncd:master Jul 8, 2020
@dibyom dibyom deleted the update-deps branch July 9, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@wlynch wlynch wlynch approved these changes

@iancoffey iancoffey Awaiting requested review from iancoffey

@ncskier ncskier Awaiting requested review from ncskier

Assignees

@vdemeester vdemeester

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Knative Dependencies to Align with Pipelines
4 participants
@dibyom @vdemeester @tekton-robot @wlynch