Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for marshaling other types. #668

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

bigkevmcd
Copy link
Member

Changes

This adds support for marshaling bool values, and maps if they're used as the
values of expressions in a CEL overlay.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Marshaling of maps and boolean values in CEL expressions for the overlay mechanism should now work.

This adds support for marshaling bool values, and maps if they're used as the
values of expressions in a CEL overlay.
@tekton-robot tekton-robot requested review from dlorenc and wlynch July 8, 2020 16:05
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2020
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/cel.go 87.9% 89.2% 1.3

@dibyom dibyom added this to the Triggers v0.7.0 milestone Jul 9, 2020
@dibyom
Copy link
Member

dibyom commented Jul 9, 2020

/kind feature
/approve
/lgtm

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. labels Jul 9, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@tekton-robot tekton-robot merged commit 0240d7a into tektoncd:master Jul 9, 2020
@bigkevmcd bigkevmcd deleted the marshal-other-outputs branch July 29, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants