Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processTriggerSpec func to wire it to Trigger, and the corresponding unit test #686

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

dorismeixing
Copy link
Member

@dorismeixing dorismeixing commented Jul 23, 2020

unit test.

Changes

It's to create processTriggerSpec which will create resources and wire it to Trigger function with the corresponding unit testing. (Related to issue #624)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

It's to add a CLI tool to process Triggers

@tekton-robot tekton-robot requested review from dibyom and vtereso July 23, 2020 22:49
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 23, 2020
@dorismeixing
Copy link
Member Author

add reviewers @dibyom @wlynch
/assign dibyom
/assign wlynch

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 46.3% -33.7

pkg/sink/sink.go Outdated Show resolved Hide resolved
cmd/triggerRun/cmd/root.go Outdated Show resolved Hide resolved
cmd/triggerRun/cmd/root.go Outdated Show resolved Hide resolved
cmd/triggerRun/cmd/root.go Outdated Show resolved Hide resolved
cmd/triggerRun/cmd/root.go Outdated Show resolved Hide resolved
pkg/sink/sink.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 45.1% -34.9

cmd/triggerRun/cmd/root.go Outdated Show resolved Hide resolved
cmd/triggerRun/cmd/root.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 43.2% -36.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 43.2% -36.8

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2020
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 43.2% -36.8

go.mod Outdated Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 43.2% -36.8

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 24, 2020
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 43.2% -36.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 43.2% -36.8

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A couple of small comments. Also, let's add the issue number in the PR description and add a small description to the Release Notes section of the PR description. Something like Adds a CLI tool to process Triggers

cmd/triggerRun/cmd/root_test.go Outdated Show resolved Hide resolved
cmd/triggerRun/cmd/root_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/triggerRun/cmd/root.go 80.0% 43.2% -36.8

@dibyom
Copy link
Member

dibyom commented Jul 28, 2020

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@tekton-robot tekton-robot merged commit c414e33 into tektoncd:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants