Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double-logging of interceptor errors. #689

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Prevent double-logging of interceptor errors. #689

merged 1 commit into from
Jul 28, 2020

Conversation

bigkevmcd
Copy link
Member

Changes

This reduces the double logging of errors when executing interceptors.

This drops the log when executing the interceptor, but this is logged out by processTrigger.

https://github.com/bigkevmcd/triggers/blob/4b3ecb4c7260ceeb12a65d32290d4925b74b2348/pkg/sink/sink.go#L144-L148

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Prevent double-logging of errors from interceptors.

@tekton-robot tekton-robot requested review from dlorenc and vtereso July 28, 2020 10:03
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2020
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 75.5% 75.2% -0.2

afrittoli
afrittoli reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@dibyom
Copy link
Member

dibyom commented Jul 28, 2020

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@dibyom
Copy link
Member

dibyom commented Jul 28, 2020

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 28, 2020
@tekton-robot tekton-robot merged commit 4b5469f into tektoncd:master Jul 28, 2020
@bigkevmcd bigkevmcd deleted the reduce-error-logging branch July 29, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@dlorenc dlorenc Awaiting requested review from dlorenc

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigkevmcd @tekton-robot @dibyom @afrittoli