-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestaps in logs #802
Conversation
/cc @mattmoor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can we also add this to the EventListener's logger as well? (That will fix #800)
|
So, the event listener seems to be using What I can do is to update the default content of the map, which is used when the config map is not available. |
The controller and webhook logs do not include timestamps, which makes troubleshooting issues much harder. Adding the timestamps into the default logging configuration. Fixes: tektoncd#800 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
b5a1b66
to
dfbe6bc
Compare
Seems to be working fine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
The controller and webhook logs do not include timestamps, which
makes troubleshooting issues much harder.
Adding the timestamps into the default logging configuration.
Fixes: #800
Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
/kind feature