Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zaptest logger in tests #833

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Use zaptest logger in tests #833

merged 1 commit into from
Nov 20, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Nov 19, 2020

Changes

This will print debug/info test logs if we use go test -v or if a test fails.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

/kind cleanup

@dibyom
Use zaptest logger in tests
2d6cf6d 
This will print debug/info test logs if we use `go test -v` or if a test fails.

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom requested review from khrm and savitaashture November 19, 2020 20:37
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 19, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2020
savitaashture
savitaashture reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
khrm
khrm approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
@tekton-robot tekton-robot merged commit 713da5a into tektoncd:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@khrm khrm khrm approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@khrm khrm

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dibyom @tekton-robot @khrm @savitaashture