-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom object to triggers eventlistener #958
Add support for custom object to triggers eventlistener #958
Conversation
The following is the coverage report on the affected files.
|
518a884
to
5c3f8b8
Compare
The following is the coverage report on the affected files.
|
5c3f8b8
to
e99757e
Compare
The following is the coverage report on the affected files.
|
e99757e
to
6395d74
Compare
The following is the coverage report on the affected files.
|
6395d74
to
12241f6
Compare
The following is the coverage report on the affected files.
|
12241f6
to
e1d7ee0
Compare
The following is the coverage report on the affected files.
|
e1d7ee0
to
6100c61
Compare
The following is the coverage report on the affected files.
|
6100c61
to
ced5e0f
Compare
The following is the coverage report on the affected files.
|
ced5e0f
to
c353193
Compare
The following is the coverage report on the affected files.
|
c353193
to
8f82eac
Compare
The following is the coverage report on the affected files.
|
8f82eac
to
0a06f65
Compare
The following is the coverage report on the affected files.
|
0a06f65
to
fdc1ebc
Compare
The following is the coverage report on the affected files.
|
fdc1ebc
to
0f90d52
Compare
Thanks I think that's ok for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! almost there. Couple of minor comments.
Also: @sergetron do you want to review the docs for this PR?
The following is the coverage report on the affected files.
|
examples/custom-resource/README.md
Outdated
In [`HMAC`](https://www.freeformatter.com/hmac-generator.html) `string` is the *body payload ex:* `{"action": "opened", "pull_request":{"head":{"sha": "28911bbb5a3e2ea034daf1f6be0a822d50e31e73"}},"repository":{"clone_url": "https://github.com/tektoncd/triggers.git"}}` | ||
and `secretKey` is the *given secretToken ex:* `1234567`. | ||
|
||
1. You should see a new TaskRun that got created: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above about "should".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As TriggerTemplate of EL explicitly creates TaskRun so i believe "should" suites here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, "You will see the newly created TaskRun
" is more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified
Thank you 👍
17c04c3
to
8549250
Compare
The following is the coverage report on the affected files.
|
@dibyom @sergetron addressed all the review comments Thank you 🙏 |
Thanks, could you squash up the commits? |
8549250
to
39fb9d7
Compare
The following is the coverage report on the affected files.
|
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
customResource
to support Knative Service for EventListener as part of TEP0008later this can be addressed as part of Status Conditions for EventListener #932
Pending:
Will work on subsequent PR for pending things
/cc @dibyom
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
Introduced new field
customResource
to support Knative Service for EventListener