-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate core interceptors to use InterceptorType CRD #976
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/assign @wlynch |
The following is the coverage report on the affected files.
|
/test pull-tekton-triggers-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some relatively minor mostly cosmetic issues, otherwise looks good to me.
The following is the coverage report on the affected files.
|
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Verified locally it works as expected
Thank you 👍
Just one question if user want to write custom interceptor what all things they have to take care? do we have any steps/instructions?
Docs coming for those as part of #1001 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With tektoncd#976, core interceptors are now installed as instances of the ClusterInterceptor CRD. They are also bundled in a separate YAML file. We need to wait for the Interceptors CRD to become established before we can create the core interceptors. Otherwise, we run the risk of trying to create the core-interceptors too early leading to installation errors. In tektoncd#976 we fixed the e2e install scripts to account for these changes but not the release pipeline. This commit updates the release pipeline to add the new interceptors YAML as part of the release assets. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
With tektoncd#976, core interceptors are now installed as instances of the ClusterInterceptor CRD. They are also bundled in a separate YAML file. We need to wait for the Interceptors CRD to become established before we can create the core interceptors. Otherwise, we run the risk of trying to create the core-interceptors too early leading to installation errors. In tektoncd#976 we fixed the e2e install scripts to account for these changes but not the release pipeline. This commit updates the release pipeline to add the new interceptors YAML as part of the release assets. Fixes tektoncd#1006 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
With #976, core interceptors are now installed as instances of the ClusterInterceptor CRD. They are also bundled in a separate YAML file. We need to wait for the Interceptors CRD to become established before we can create the core interceptors. Otherwise, we run the risk of trying to create the core-interceptors too early leading to installation errors. In #976 we fixed the e2e install scripts to account for these changes but not the release pipeline. This commit updates the release pipeline to add the new interceptors YAML as part of the release assets. Fixes #1006 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Changes
Migrate core interceptors to use InterceptorType CRD
This commit does the following:
new InterceptorType CRD.
Interceptor's URL.
Fixes #868
This is NOT a breaking change since users can still configure their interceptors in the same way was before. Changes to the way a TriggerInterceptor is configured is coming in #869.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
Depends on #960