Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite triggertemplates.md for clarity and flow #981

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Rewrite triggertemplates.md for clarity and flow #981

merged 1 commit into from
Mar 5, 2021

Conversation

tualeron
Copy link
Contributor

@tualeron tualeron commented Mar 4, 2021

Changes

Rewrites triggertemplates.md for clarity and flow

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 4, 2021
@tualeron
Copy link
Contributor Author

tualeron commented Mar 4, 2021

/kind documentation

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 4, 2021
dibyom
dibyom reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the naming. Otherwise LGTM!

docs/triggertemplates.md Outdated Show resolved Hide resolved
@tualeron
Rewrite triggertemplates.md for clarity and flow
cbb8890 
Rewrites triggertemplates.md for clarity and flow
@dibyom
Copy link
Member

dibyom commented Mar 5, 2021

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@tekton-robot tekton-robot merged commit 376b068 into tektoncd:master Mar 5, 2021
@tualeron tualeron deleted the patch-1 branch March 5, 2021 19:12
@AlanGreene AlanGreene mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@savitaashture savitaashture Awaiting requested review from savitaashture

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tualeron @dibyom @tekton-robot