Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite triggerbindings.md for clarity and flow #988

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Rewrite triggerbindings.md for clarity and flow #988

merged 1 commit into from
Mar 10, 2021

Conversation

tualeron
Copy link
Contributor

@tualeron tualeron commented Mar 9, 2021

Changes

Rewrites triggerbindings.md for clarity and flow and merges content from clustertriggerbindings.md.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot requested review from iancoffey and khrm March 9, 2021 18:17
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2021
@tualeron
Copy link
Contributor Author

tualeron commented Mar 9, 2021

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 9, 2021
Base automatically changed from master to main March 10, 2021 15:03
dibyom
dibyom reviewed Mar 10, 2021
View reviewed changes
docs/triggerbindings.md Outdated Show resolved Hide resolved
@dibyom
Copy link
Member

dibyom commented Mar 10, 2021

yeah, this looks great! (just squash up the commits and we should be good to go!)
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@tualeron
Rewrite triggerbindings.md for clarity and flow
8f832fd 
Rewrites triggerbindings.md for clarity and flow and merges content from clustertriggerbindings.md.
@tualeron
Copy link
Contributor Author

Commits squashed. Can someone LGTM please?

@dibyom
Copy link
Member

dibyom commented Mar 10, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@tekton-robot tekton-robot merged commit 087f018 into tektoncd:main Mar 10, 2021
@tualeron tualeron deleted the patch-1 branch March 10, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@iancoffey iancoffey Awaiting requested review from iancoffey

@khrm khrm Awaiting requested review from khrm

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tualeron @dibyom @tekton-robot