-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eventlisteners.md #993
Conversation
I believe these are typos; I had to remove them in my own pipeline to get the `cel` expressions working.
Hi @djfinnoy. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks, you are right. We changed the examples but not the examples embedded in the docs. /lgtm |
I was wrong -- looks like we need to update the examples too. @djfinnoy would you mind updating examples/eventlisteners/cel-eventlistener-no-filter.yaml as well? |
/test pull-tekton-triggers-integration-tests |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I believe these lines contain typos; I had to modify them in my own pipeline to get the
cel
expressions working.Changes
Edits to documentation.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes