Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workflow refactoring #307

Merged
merged 4 commits into from
Dec 17, 2022
Merged

chore: workflow refactoring #307

merged 4 commits into from
Dec 17, 2022

Conversation

rustatian
Copy link
Collaborator

@rustatian rustatian commented Dec 16, 2022

Reason for This PR

  • WorkflowDefinition refactoring

Description of Changes

  • Move LocalActivityFn to the separate structure
  • Protect MessageQueue with mutex
  • Add more logs

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added A-other Area: other C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Dec 16, 2022
@rustatian rustatian added this to the v2.x milestone Dec 16, 2022
@rustatian rustatian requested a review from wolfy-j December 16, 2022 19:52
@rustatian rustatian self-assigned this Dec 16, 2022
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2022

Codecov Report

Merging #307 (bd7daf3) into master (b06b5cc) will increase coverage by 0.53%.
The diff coverage is 7.46%.

@@            Coverage Diff            @@
##           master    #307      +/-   ##
=========================================
+ Coverage    3.17%   3.70%   +0.53%     
=========================================
  Files          18      19       +1     
  Lines        1605    1645      +40     
=========================================
+ Hits           51      61      +10     
- Misses       1552    1582      +30     
  Partials        2       2              
Impacted Files Coverage Δ
aggregatedpool/activity.go 0.00% <0.00%> (ø)
aggregatedpool/handler.go 0.00% <0.00%> (ø)
aggregatedpool/local_activity.go 0.00% <0.00%> (ø)
aggregatedpool/workflow.go 0.00% <0.00%> (ø)
plugin.go 0.00% <0.00%> (ø)
queue/queue.go 78.57% <100.00%> (+6.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit d18b559 into master Dec 17, 2022
@rustatian rustatian deleted the chore/workflow-refactoring branch December 17, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: other C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants