diff --git a/src/Temporalio/Temporalio.csproj b/src/Temporalio/Temporalio.csproj index cfdbcfb0..1eb5023c 100644 --- a/src/Temporalio/Temporalio.csproj +++ b/src/Temporalio/Temporalio.csproj @@ -20,7 +20,7 @@ - + diff --git a/tests/Temporalio.Tests/Extensions/Hosting/TemporalWorkerServiceTests.cs b/tests/Temporalio.Tests/Extensions/Hosting/TemporalWorkerServiceTests.cs index e9981823..bd247a67 100644 --- a/tests/Temporalio.Tests/Extensions/Hosting/TemporalWorkerServiceTests.cs +++ b/tests/Temporalio.Tests/Extensions/Hosting/TemporalWorkerServiceTests.cs @@ -206,8 +206,8 @@ public async Task TemporalWorkerService_ExecuteAsync_MultipleWorkers() ["scoped-other2"] = $"tq: {taskQueue2}, counter: 6", }, result); - } - + } + [Workflow] public class TickingWorkflow { @@ -221,7 +221,7 @@ public async Task RunAsync() } } } - + [Fact] public async Task TemporalWorkerService_WorkerClientReplacement_UsesNewClient() { @@ -265,7 +265,7 @@ public async Task TemporalWorkerService_WorkerClientReplacement_UsesNewClient() // Start the host using var tokenSource = new CancellationTokenSource(); using var host = bld.Build(); - var hostTask = Task.Run(() => host.RunAsync(tokenSource.Token)); + var hostTask = Task.Run(() => host.RunAsync(tokenSource.Token)); // Confirm the first ticking workflow has completed a task but not the second workflow await AssertMore.HasEventEventuallyAsync(handle1, e => e.WorkflowTaskCompletedEventAttributes != null); @@ -300,9 +300,13 @@ public class WorkflowV2 public async Task RunAsync() => "done-v2"; } - [Fact] + [SkippableFact] public async Task TemporalWorkerService_ExecuteAsync_MultipleVersionsSameQueue() { + // This only applies to legacy versioning and therefore is ok to skip (and remove in the + // future) + throw new SkipException("Since 1.24 this test is slow because legacy versioning has a known slowdown"); +#pragma warning disable IDE0035, CS0162 // We know the below is now dead code var taskQueue = $"tq-{Guid.NewGuid()}"; // Build with two workers on same queue but different versions var bld = Host.CreateApplicationBuilder();