Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite RPC headers #1249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not overwrite RPC headers #1249

wants to merge 1 commit into from

Conversation

wxing1292
Copy link
Contributor

What was changed

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@wxing1292 wxing1292 requested a review from a team as a code owner September 26, 2023 23:39
bergundy
bergundy reviewed Sep 26, 2023
View reviewed changes
internal/internal_utils.go
if !ok {
ctx = metadata.NewOutgoingContext(ctx, cb.Headers)
} else {
ctx = metadata.NewOutgoingContext(ctx, metadata.Join(md, cb.Headers))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we join in reverse order and allow context metadata to overwrite cb.Headers?

@bergundy
Copy link
Member

Thanks!

Can you provide a test that accompanies this change and a bit more details as to what this PR exactly does and why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxing1292 @bergundy