From 3d03f9517c71cfa8467ad318f503d881b170dde6 Mon Sep 17 00:00:00 2001 From: Chad Retz Date: Tue, 28 Sep 2021 08:12:51 -0500 Subject: [PATCH 1/2] Skip interrupt signal test on windows --- internal/internal_worker_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/internal_worker_test.go b/internal/internal_worker_test.go index 1a8cf6edf..dffbccad1 100644 --- a/internal/internal_worker_test.go +++ b/internal/internal_worker_test.go @@ -30,6 +30,7 @@ import ( "fmt" "os" "reflect" + "runtime" "strings" "sync" "testing" @@ -1474,6 +1475,10 @@ func (s *internalWorkerTestSuite) TestCreateWorkerWithDataConverter() { } func (s *internalWorkerTestSuite) TestCreateWorkerRun() { + // Windows doesn't support signalling interrupt + if runtime.GOOS == "windows" { + s.T().Skip("Not supported on windows") + } // Create service endpoint mockCtrl := gomock.NewController(s.T()) service := workflowservicemock.NewMockWorkflowServiceClient(mockCtrl) From cd76eb468efb6cfcf309de86279f594afee511da Mon Sep 17 00:00:00 2001 From: Chad Retz Date: Tue, 28 Sep 2021 14:24:36 -0500 Subject: [PATCH 2/2] Make comment complete sentence Co-authored-by: Alex Shtin --- internal/internal_worker_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/internal_worker_test.go b/internal/internal_worker_test.go index dffbccad1..ff1c698ee 100644 --- a/internal/internal_worker_test.go +++ b/internal/internal_worker_test.go @@ -1475,7 +1475,7 @@ func (s *internalWorkerTestSuite) TestCreateWorkerWithDataConverter() { } func (s *internalWorkerTestSuite) TestCreateWorkerRun() { - // Windows doesn't support signalling interrupt + // Windows doesn't support signalling interrupt. if runtime.GOOS == "windows" { s.T().Skip("Not supported on windows") }