chore: Deprecate WorkflowLogInterceptor
#1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-activity-log-interceptor
…e-activity-log-interceptor
bergundy
reviewed
Nov 13, 2023
| throw error; | ||
| } | ||
| ); | ||
| // Avoid showing this interceptor in stack trace query |
Member
There was a problem hiding this comment.
Suggested change
| // Avoid showing this interceptor in stack trace query | |
| // Avoid showing this promise in stack trace query |
bergundy
approved these changes
Nov 13, 2023
…e-workflow-log-interceptor
…e-workflow-log-interceptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Attributes from the current Workflow are now automatically included as metadata on every log entries by the Workflow Worker, and some key events of the Workflow's lifecycle will automatically be logged (at 'DEBUG' level for most messages; 'WARN' for failures).
Deprecated
WorkflowLogInterceptor; it is now a no-op.Deprecated
appendDefaultInterceptors. It is now a no-op in all cases, except when a custom logger is supplied, in which case it adds aActivityInboundLogInterceptorto register that custom logger on Activity context.Why
appendDefaultInterceptors()if they were to register custom interceptors, which was error prone and a recurring source of support question.