Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added limit to number of 'available activities' list when calling an unregistered activity #1559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KaiStevenson
Copy link

What was changed

When emitting an 'Activity function xyz is not registered on this Worker' error, the number of activities listed in 'available activities are:' has been capped to a maximum of 10. It will be of the format 'Activity function xyz is not registered on this Worker, available activities: activity1, activity2 ... activity10 and 37 others.'

Why?

'Available activities are:' can be a useful hint as to which worker picked up the activity, and can immediately highlight problems if there are, in fact, no registered activities! But for workers with hundreds or thousands of activities registered, these logs quickly become huge, taking up too much storage and memory.

@KaiStevenson KaiStevenson requested a review from a team as a code owner November 7, 2024 23:39
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants