diff --git a/components/nexusoperations/executors.go b/components/nexusoperations/executors.go index e29a073836e..f742c64f4ef 100644 --- a/components/nexusoperations/executors.go +++ b/components/nexusoperations/executors.go @@ -339,7 +339,12 @@ func (e taskExecutor) saveResult(ctx context.Context, env hsm.Environment, ref h case string((&commonpb.Link_WorkflowEvent{}).ProtoReflect().Descriptor().FullName()): link, err := ConvertNexusLinkToLinkWorkflowEvent(nexusLink) if err != nil { - // silently ignore for now + // TODO(rodrigozhou): links are non-essential for the execution of the workflow, + // so ignoring the error for now; we will revisit how to handle these errors later. + e.Logger.Error( + fmt.Sprintf("failed to parse link to %q: %s", nexusLink.Type, nexusLink.URL), + tag.Error(err), + ) continue } links = append(links, &commonpb.Link{ diff --git a/service/frontend/nexus_handler.go b/service/frontend/nexus_handler.go index 0b49f395821..799eb6619c0 100644 --- a/service/frontend/nexus_handler.go +++ b/service/frontend/nexus_handler.go @@ -393,7 +393,9 @@ func (h *nexusHandler) StartOperation( for _, link := range t.AsyncSuccess.GetLinks() { linkURL, err := url.Parse(link.Url) if err != nil { - // silently ignore for now + // TODO(rodrigozhou): links are non-essential for the execution of the workflow, + // so ignoring the error for now; we will revisit how to handle these errors later. + oc.logger.Error(fmt.Sprintf("failed to parse link url: %s", link.Url), tag.Error(err)) continue } nexusLinks = append(nexusLinks, nexus.Link{