Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new syntax to include UI static files, upgrade to go v1.18 #86

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Jan 8, 2022

What was changed

Note: golang v1.18 is currently in beta 1
upd. released! https://go.dev/blog/go1.18

Why?

Allows to automate updating the UI files instead of manually as here

//go:embed generated/ui/* generated/ui/_app/assets/pages/* generated/ui/_app/chunks/* generated/ui/_app/pages/* generated/ui/_app/assets/pages/namespaces/\[namespace\]/queue/\[queue\]/* generated/ui/_app/assets/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/compact/activity-\[eventId\]/* generated/ui/_app/assets/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/_* generated/ui/_app/assets/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/_* generated/ui/_app/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/* generated/ui/_app/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/* generated/ui/_app/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/full/* generated/ui/_app/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/compact/* generated/ui/_app/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/json/* generated/ui/_app/pages/namespaces/\[namespace\]/workflows/\[workflow\]/\[run\]/history/compact/activity-\[eventId\]/* generated/ui/_app/pages/namespaces/\[namespace\]/workflows/* generated/ui/_app/pages/namespaces/\[namespace\]/*

Checklist

  1. Closes

  2. How was this tested:

Verified that all common UI pages and static files load

  1. Any docs updates needed?

@feedmeapples feedmeapples marked this pull request as draft January 8, 2022 00:09
@feedmeapples feedmeapples marked this pull request as draft January 8, 2022 00:09
@feedmeapples
Copy link
Contributor Author

@jlegrone fyi since this may affect temporalite

@feedmeapples feedmeapples requested review from stevekinney and removed request for stevekinney January 8, 2022 00:23
@feedmeapples feedmeapples force-pushed the go1.18 branch 3 times, most recently from 3b7b8f2 to 1b91191 Compare January 14, 2022 16:31
@feedmeapples feedmeapples marked this pull request as ready for review March 16, 2022 15:17
@feedmeapples feedmeapples merged commit 34df677 into main Mar 16, 2022
@feedmeapples feedmeapples deleted the go1.18 branch March 16, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants